Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unsafe ref access during render #8054

Draft
wants to merge 1 commit into
base: add-million-lint-mode
Choose a base branch
from
Draft

fix: unsafe ref access during render #8054

wants to merge 1 commit into from
+5 −15

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Dec 13, 2024

Description

What to review

Testing

Notes for release

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:09pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:09pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:09pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 13, 2024 7:09pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Dec 13, 2024 7:05 PM (UTC)

❌ Failed Tests (6) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 4m 27s 0 0 6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 3m 3s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 54s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 19:05:59 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 24.4 efps (41ms) 22.2 efps (45ms) +4ms (+9.8%) ✅
article (body) 56.8 efps (18ms) 72.5 efps (14ms) -4ms (-21.6%) ✅
article (string inside object) 24.4 efps (41ms) 23.8 efps (42ms) +1ms (+2.4%) ✅
article (string inside array) 22.7 efps (44ms) 22.2 efps (45ms) +1ms (+2.3%) ✅
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%) ✅
recipe (description) 58.8 efps (17ms) 60.6 efps (17ms) -1ms (-2.9%) ✅
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%) ✅
synthetic (title) 17.1 efps (59ms) 16.7 efps (60ms) +2ms (+2.6%) ✅
synthetic (string inside object) 18.2 efps (55ms) 16.7 efps (60ms) +5ms (+9.1%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 45ms 83ms 233ms 330ms 11.9s
article (body) 18ms 20ms 32ms 158ms 213ms 5.7s
article (string inside object) 41ms 45ms 54ms 252ms 235ms 7.3s
article (string inside array) 44ms 46ms 53ms 181ms 137ms 7.3s
recipe (name) 19ms 20ms 24ms 43ms 0ms 6.6s
recipe (description) 17ms 19ms 22ms 38ms 0ms 4.5s
recipe (instructions) 5ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 59ms 62ms 70ms 127ms 723ms 14.1s
synthetic (string inside object) 55ms 58ms 64ms 324ms 232ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 48ms 57ms 179ms 182ms 12.6s
article (body) 14ms 15ms 19ms 92ms 190ms 5.3s
article (string inside object) 42ms 44ms 55ms 170ms 396ms 7.5s
article (string inside array) 45ms 48ms 53ms 186ms 163ms 7.3s
recipe (name) 19ms 20ms 26ms 39ms 0ms 6.9s
recipe (description) 17ms 18ms 20ms 34ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 27ms 0ms 3.0s
synthetic (title) 60ms 64ms 70ms 274ms 899ms 14.2s
synthetic (string inside object) 60ms 62ms 90ms 545ms 1379ms 9.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stipsan